Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

Updated CSS #104

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated CSS #104

wants to merge 1 commit into from

Conversation

Rohitrky2021
Copy link

@Rohitrky2021 Rohitrky2021 commented Mar 22, 2023

Removed the margin property for h5 elements: I found that this margin was causing too much space between the h5 and the previous element, making the card look unbalanced.

Changed the font size and line height for h2 elements: I increased the font size to make the heading more prominent, and adjusted the line height to improve legibility.

Added padding to the top of the card body: This was done to create some visual space between the heading and the body content.

Changed the font family for p elements: I changed the font family to match that of the h2 element, creating a consistent typography throughout the card.

Adjusted the font size and color for h5 elements: I decreased the font size slightly to make the h5 element less prominent, and adjusted the color to make it more visible against the background.

Pull Request Template

Description

Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added corresponding tests.
  • Any dependent changes have been merged and published in downstream modules.

Removed the margin property for h5 elements: I found that this margin was causing too much space between the h5 and the previous element, making the card look unbalanced.

Changed the font size and line height for h2 elements: I increased the font size to make the heading more prominent, and adjusted the line height to improve legibility.

Added padding to the top of the card body: This was done to create some visual space between the heading and the body content.

Changed the font family for p elements: I changed the font family to match that of the h2 element, creating a consistent typography throughout the card.

Adjusted the font size and color for h5 elements: I decreased the font size slightly to make the h5 element less prominent, and adjusted the color to make it more visible against the background.
@github-actions
Copy link

⚡️ Deploying PR Preview...

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in UI

Copy link
Member

@nehagup nehagup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rohitrky2021 can you please post before after screenshot?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants